Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] jsx-key: detect conditional returns #3630

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[Fix] jsx-key: detect conditional returns #3630

merged 1 commit into from
Sep 5, 2023

Conversation

yialo
Copy link
Contributor

@yialo yialo commented Sep 5, 2023 •
edited
Loading

Catch React key absence for conditional return without block statement:

const TestCase = () => {
  const list = [1, 2, 3, 4, 5];
  return (
    <div>
      {list.map(item => {
        if (item < 2) return <div>{item}</div>;
        else if (item < 5) return <div />;
        else return <div />;
      })}
    </div>
  );
};

@yialo yialo marked this pull request as ready for review September 5, 2023 10:08
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #3630 (9acfec2) into master (422ff33) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9acfec2 differs from pull request most recent head ecadb92. Consider uploading reports for the commit ecadb92 to get more accurate results

@@           Coverage Diff           @@
##           master    #3630   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         132      132           
  Lines        9358     9360    +2     
  Branches     3425     3426    +1     
=======================================
+ Hits         9138     9140    +2     
  Misses        220      220
Files Changed Coverage Δ
lib/rules/jsx-key.js 99.16% <100.00%> (+0.01%) ⬆️

ljharb
ljharb approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward, thanks!

@ljharb ljharb force-pushed the fix/jsx-key-unblocked-conditional-return branch from 9acfec2 to ecadb92 Compare September 5, 2023 17:22
@ljharb ljharb changed the title [fix] jsx-key: unblocked conditional return [Fix] jsx-key: detect conditional returns Sep 5, 2023
@ljharb ljharb merged commit ecadb92 into jsx-eslint:master Sep 5, 2023
290 checks passed
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request May 24, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
Open
@mjperrins mjperrins mentioned this pull request May 30, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Jun 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jun 3, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jun 3, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 3, 2024
Open
This was referenced Jun 3, 2024
Open
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jun 4, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 5, 2024
Open
@cezaraugusto cezaraugusto mentioned this pull request Jun 6, 2024
Merged
@paaschdigital paaschdigital mentioned this pull request Jun 7, 2024
Open
@MANAALHARBI MANAALHARBI mentioned this pull request Jun 8, 2024
Merged
@richyhoopd richyhoopd mentioned this pull request Jun 18, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 18, 2024
Open
This was referenced Jun 18, 2024
Open
Open
Open
This was referenced Oct 3, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@scatools-demo scatools-demo mentioned this pull request Oct 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Oct 4, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 4, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 4, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 4, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@scatools-demo scatools-demo mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yialo @ljharb